virt.virtnet : update vm.virtnet when guest reboot #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting a guest with one nic device, then starting a guest with two nics (not removing env), the second nic can not be initialized correctly. When booting a guest with nic_extra_params, then booting another guest without this option, the second guest will boot with nic_extra_params unexpectedly. The root cause of these issues is that we don't update virtnet when the VM object is preprocessed. Signed-off-by: Yunping Zheng <[email protected]>
lmr
added a commit
that referenced
this pull request
Dec 4, 2013
virt.virtnet : update vm.virtnet when guest reboot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a guest with one nic device, then
starting a guest with two nics (not removing env),
the second nic can not be initialized correctly.
When booting a guest with nic_extra_params, then
booting another guest without this option, the
second guest will boot with nic_extra_params
unexpectedly.
The root cause of these issues is that we don't
update virtnet when the VM object is preprocessed.
Signed-off-by: Yunping Zheng [email protected]